Skip to content

Conversation

@bennypowers
Copy link
Member

What I did

  1. add scroll spy hashchange support

Testing Instructions

  1. jump links demo
  2. click around on two or three jump links
  3. reload the page, hit back/forward a few times to change the hash
  4. observer that jump links activates the correct link according to the current hash

@changeset-bot
Copy link

changeset-bot bot commented Apr 6, 2025

🦋 Changeset detected

Latest commit: 5d9abfa

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@patternfly/pfe-core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Apr 6, 2025

✅ Commitlint tests passed!

More Info
{
  "valid": true,
  "errors": [],
  "warnings": [],
  "input": "feat(core): scroll-spy-controller hashchange"
}

@github-actions
Copy link
Contributor

github-actions bot commented Apr 6, 2025

Deploy Preview for patternfly-elements ready!

Name Link
🔨 Latest commit 5239518
😎 Deploy Preview https://deploy-preview-2900--patternfly-elements.netlify.app/

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added the AT passed Automated testing has passed label Apr 6, 2025
@netlify
Copy link

netlify bot commented Apr 6, 2025

Deploy Preview for patternfly-elements ready!

Name Link
🔨 Latest commit 5d9abfa
🔍 Latest deploy log https://app.netlify.com/sites/patternfly-elements/deploys/67f272f32613e0000825b716
😎 Deploy Preview https://deploy-preview-2900--patternfly-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 6, 2025

SSR Test Run for 29a9799: Report

@github-actions
Copy link
Contributor

github-actions bot commented Apr 6, 2025

SSR Test Run for 38cd13f: Report

@github-actions
Copy link
Contributor

github-actions bot commented Apr 6, 2025

SSR Test Run for 269050b: Report

@github-actions
Copy link
Contributor

github-actions bot commented Apr 6, 2025

SSR Test Run for f91b729: Report

@github-actions
Copy link
Contributor

github-actions bot commented Apr 6, 2025

SSR Test Run for 5239518: Report

@bennypowers bennypowers merged commit a2f3254 into main Apr 6, 2025
16 checks passed
@bennypowers bennypowers deleted the feat/scroll-spy/hashchange branch April 6, 2025 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AT passed Automated testing has passed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants