Skip to content

Conversation

@bennypowers
Copy link
Member

What I did

  1. activate the url hash jump link item on page load

Testing Instructions

  1. copy to rhds node_modules
  2. load up the rh-jump-links demos
  3. click on a jump link (hash)
  4. reload the page
  5. BEHOLD: hashed item is active

@changeset-bot
Copy link

changeset-bot bot commented Mar 31, 2025

⚠️ No Changeset found

Latest commit: bc2d5e9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Mar 31, 2025

✅ Commitlint tests passed!

More Info
{
  "valid": true,
  "errors": [],
  "warnings": [],
  "input": "fix(core): activate scroll spy link on connect"
}

@netlify
Copy link

netlify bot commented Mar 31, 2025

Deploy Preview for patternfly-elements ready!

Name Link
🔨 Latest commit e3b739c
😎 Deploy Preview https://deploy-preview-2898--patternfly-elements.netlify.app/

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added the AT passed Automated testing has passed label Mar 31, 2025
@github-actions
Copy link
Contributor

SSR Test Run for d53b181: Report

@github-actions
Copy link
Contributor

SSR Test Run for db27fe7: Report

Copy link
Collaborator

@adamjohnson adamjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Links Get Tracked Markers

@bennypowers bennypowers enabled auto-merge (squash) April 3, 2025 13:03
@bennypowers bennypowers merged commit 57a5c57 into main Apr 3, 2025
18 of 21 checks passed
@bennypowers bennypowers deleted the fix/core/scroll-spy/for-rh-jump-links branch April 3, 2025 13:05
@github-actions

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AT passed Automated testing has passed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants