feat: add jobId-based cancellation for upload and download operations#129
Draft
patrickkabwe wants to merge 3 commits intomainfrom
Draft
feat: add jobId-based cancellation for upload and download operations#129patrickkabwe wants to merge 3 commits intomainfrom
patrickkabwe wants to merge 3 commits intomainfrom
Conversation
- Add cancelUpload and cancelDownload methods that return boolean - Update uploadFile to return jobId immediately for cancellation support - Update downloadFile to return NitroDownloadResult with jobId and file - Fix race conditions in iOS uploader and downloader by using sync for state initialization - Add proper state management for tracking upload/download jobs on both platforms - Ensure progress callbacks work reliably with proper thread-safe state access
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
- Remove duplicate NitroDownloadResult definitions - Use generated NitroDownloadResult from nitrogen on both platforms - Fix return type mismatch in Android HybridNitroFS - Fix return type mismatch in iOS HybridNitroFs
- Store upload continuations to propagate errors to callers - Implement didCompleteWithError delegate method to handle errors - Check HTTP response status codes and throw errors for non-2xx responses - Handle cancellation errors properly - Remove continuation immediately to prevent double-resume - Fix race condition by ensuring state initialization before task resume - Upload now waits for completion and properly propagates errors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for cancelling upload and download operations by returning a
jobIdfrom bothuploadFileanddownloadFilemethods.Usage Example
Testing