Skip to content

chore: remove pnpm from CI workflow package managers#316

Merged
patrickkabwe merged 1 commit intomainfrom
fix/temp-rm-pnpm
Aug 17, 2025
Merged

chore: remove pnpm from CI workflow package managers#316
patrickkabwe merged 1 commit intomainfrom
fix/temp-rm-pnpm

Conversation

@patrickkabwe
Copy link
Owner

@patrickkabwe patrickkabwe commented Aug 17, 2025

Summary by CodeRabbit

  • Chores
    • Updated CI package generation to run only with bun and yarn; pnpm is no longer included.
    • Adjusted mobile build test jobs to use bun and yarn exclusively, removing pnpm from the test matrices.
    • Reduced the number of CI matrix combinations accordingly, resulting in fewer jobs executed.
    • pnpm-specific setup steps and paths in CI are now unreachable; existing flows continue for bun and yarn.

@patrickkabwe patrickkabwe merged commit 9736d69 into main Aug 17, 2025
1 of 2 checks passed
@coderabbitai
Copy link

coderabbitai bot commented Aug 17, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

The CI workflows were updated to remove pnpm from job matrices. In generate-package.yml and test-nitro-cli.yml, matrices now include only bun and yarn. pnpm-specific setup branches become unreachable, reducing total job combinations and keeping install/build/test paths for bun and yarn intact.

Changes

Cohort / File(s) Summary of Changes
Generate Package CI matrix update
\.github/workflows/generate-package.yml
Removed pnpm from pm matrix; matrix now uses ['bun','yarn']; pnpm-specific steps/branches become unreachable; total job count reduced.
Nitro CLI test matrices update
\.github/workflows/test-nitro-cli.yml
Dropped pnpm from pm matrices for iOS and Android test jobs; flows proceed only with bun and yarn; pnpm setup paths are no longer used.

Sequence Diagram(s)

sequenceDiagram
  participant Dev as GitHub Actions
  participant Matrix as Matrix (pm, package-type)
  participant Runner as Runner
  participant Tool as pm (bun|yarn)

  Dev->>Matrix: Expand jobs (pm ∈ {bun,yarn})
  Matrix->>Runner: Start job
  Runner->>Tool: Setup package manager
  Runner->>Tool: Install dependencies
  Runner->>Tool: Build / Test
  Tool-->>Runner: Exit status
  Runner-->>Dev: Report results
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Poem

I hop through YAML fields at night,
Trimming paths to set things right—
No more pnpm in my run,
Just yarn and bun beneath the sun.
CI hums, succinct and spry,
A tidy warren, jobs hop by. 🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 81a99d3 and 2f45f1b.

📒 Files selected for processing (2)
  • .github/workflows/generate-package.yml (1 hunks)
  • .github/workflows/test-nitro-cli.yml (2 hunks)
✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/temp-rm-pnpm

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant