feat(e2e): Complete E2E testing tasks - taxonomy, negative paths, and fixes #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Completes tasks: - task:e2e:00-contracts-and-taxonomy: Added comprehensive test taxonomy section to docs/testing.md - task:e2e:03-core-flows: Verified all required data-testid attributes exist in templates - task:e2e:04-negatives: Added e2e/negative.spec.ts with 7 negative path scenarios Changes: - docs/testing.md: - Removed duplicate content (lines 99-231) - Added "Test Taxonomy and Organization" section with 5 test types - Documented test markers and their purposes - Added comprehensive examples and best practices - Updated UI selectors documentation - e2e/negative.spec.ts (NEW): - Empty state handling (no scans) - Invalid path scanning error handling - Files page loads with no providers - Invalid provider browsing - Scan form validation - Optional dependencies graceful degradation Test coverage now complete for E2E smoke, core flows, and negative paths. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
The global-setup was using 'python' which doesn't exist on many Linux systems. Now uses python3 on non-Windows platforms, python on Windows. This fixes E2E test failures due to 'spawn python ENOENT' errors. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
- Add token parameter to checkout action - Configure git credentials helper to use GITHUB_TOKEN for submodule access - Fixes authentication error when cloning dev submodule in CI 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Completes the remaining E2E testing tasks from the Ready Queue:
Changes
Documentation (task:e2e:00-contracts-and-taxonomy)
Test Coverage (task:e2e:03-core-flows)
data-testidattributes exist in templates:nav-files,header,home-recent-scansin base.html/index.htmlfiles-title,files-rootin datasets.htmlgraph-explorer-rootin map.htmlNegative Path Tests (task:e2e:04-negatives)
Bug Fixes
spawn python ENOENTerrorpython3on Linux/macOS,pythonon WindowsTest Results
Python tests (pytest)
E2E tests (Playwright)
Task Status Update
All 5 E2E priority tasks (RICE: 999) now complete:
Checklist
🤖 Generated with Claude Code