Introduce a Mapped Guesser#143
Merged
DavidBadura merged 1 commit intopatchlevel:1.14.xfrom Feb 11, 2026
Merged
Conversation
Member
DanielBadura
left a comment
DanielBadura
left a comment
There was a problem hiding this comment.
Is it because of performance reasons or why would you not want to use attributes?
DavidBadura
approved these changes
Feb 11, 2026
There's currently no easy way to avoid adding attributes in order to configure which normalizers to use for which types. This `MappedGuesser` is a trivial Guesser implementation allowing users to specify a map of `Type::class => Normalizer::class` as an alternative to adding attributes to targets
gsteel
force-pushed
the
mapped-guesser
branch
from
c674bcd to
0c1658b
Compare
Contributor
Author
No - it's more to do with not wanting to import symbols from this lib into domain code. Attributes are a coupling of sorts, so if I have my own |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's currently no easy way to avoid adding attributes in order to configure which normalizers to use for which types.
This
MappedGuesseris a trivial Guesser implementation allowing users to specify a map ofType::class => Normalizer::classas an alternative to adding attributes to targets