Add support for sharp (#) and flat (b) notes for playNote #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`whichButtonsOn()` returns a `uint8_t` that has a bit set for each button (button1 .. bit1 .. 0b0000 0010, button2 .. bit2 ...) `firstButtonOn()` returns the number of the lowest number button 1, 2, 3 or 4..
`whichButtonsOn()` returns a `uint8_t` that contains a bit mask for each pressed button (button1 .. bit1 .. 0b00000010, button2 ..bit2 .. 0b00000100, ...) `firstButtonOn()` returns the number of the lowest number button currently pressed (1, 2, 3 or 4).
Member
|
I just added sharp and flat support today as well! The example that goes with it is pretty nuts. Will submit a PR tomorrow ;-) |
Author
|
This was my encounter with that topic (Game of Thrones ;-) ) |
Member
|
Thanks for the submission! We have a few of these now for sharps and flats and will get this functionality added soon :) Do you want to rebase/resubmit with just the button additions? |
Author
|
Yup, I originally wanted to submit that as a seperate PR, but being a GitHub noob, my commits just got funneled into this one 😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fixed some glitch with not Serial.printing the first note in a song in playSong()