Skip to content

Area beginWindowMove beginWindowResize #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
mischnic wants to merge 5 commits into
base: 0_3_0
Choose a base branch
from
Open

Area beginWindowMove beginWindowResize #105

mischnic wants to merge 5 commits into from

Conversation

@mischnic
Copy link
Collaborator

@mischnic mischnic commented May 4, 2018

Closes #99

@mischnic mischnic changed the base branch from master to 0_3_0 May 4, 2018 09:57
mischnic
mischnic commented May 4, 2018
View reviewed changes
src/UiArea/UiAreaHandler.cc
void MouseEvent(UiAreaHandler *self, uiArea *area, uiAreaMouseEvent *event) {
UiAreaMouseEvent *ev = new UiAreaMouseEvent(event);
(*(self->mouseEvent))(controlsMap[uiControl(area)], ev);
(*(self->mouseEvent))((UiArea *)controlsMap[uiControl(area)], ev);
Copy link
Collaborator Author

@mischnic mischnic May 4, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the event callbacks got a UiControl object (not UiArea)

@parro-it
Copy link
Owner

parro-it commented May 4, 2018

Looks good!
BTW, do you know why libui implemented this features specifically for Area?

@mischnic
Copy link
Collaborator Author

mischnic commented May 4, 2018

Maybe for a borderless window to implement a completely own ui with a menubar?

@parro-it
Copy link
Owner

parro-it commented May 4, 2018

Works on High Sierra:

mag-04-2018 12-14-11

Will you add an example of resize to?

@mischnic
Copy link
Collaborator Author

mischnic commented May 4, 2018 •
edited
Loading

Will you add an example of resize to?

Added, please test it on High Sierra. Doesn't work for me: andlabs/libui#357

@parro-it
Copy link
Owner

parro-it commented Jun 1, 2018

Added, please test it on High Sierra.

Doesn't work on high sierra too...

@parro-it
Copy link
Owner

parro-it commented Jun 1, 2018

Since the resize feature is blocked by the libui issue, I purpose to move it to version 0_4_0 and merge only the move feature here.

@mischnic
Copy link
Collaborator Author

mischnic commented Jun 1, 2018

Since the resize feature is blocked by the libui issue, I purpose to move it to version 0_4_0 and merge only the move feature here.

Here is the PR to fix this: andlabs/libui#385

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mischnic @parro-it