feat: added support for the IPFS hash type#402
feat: added support for the IPFS hash type#4020xf333 wants to merge 1 commit intoparitytech:mainfrom
Conversation
addressing issue#379 implementation test ------------------- cargo test -p resolc ipfs cargo test -p revive-solc-json-interface ipfs Signed-off-by: 0xf333 <0x333@tuta.io>
xermicus
left a comment
There was a problem hiding this comment.
Hi, many thanks for the PR!
The end goal (to make this useful first hand) is to append it as CBOR data to the bytecode.
See also the solc documentation:
https://docs.soliditylang.org/en/latest/metadata.html#encoding-of-the-metadata-hash-in-the-bytecode
https://docs.soliditylang.org/en/latest/060-breaking-changes.html#metadata-hash-options
Sorry it doesn't say it in the issue. I added a few sentences to the issue.
|
@0xf333 After some more consideration, we might actually store the metadata hash not in the bytecode but in pallet revive. This will simplify the PR here a lot (the PR would be a lot closer to be ready). Please hold your horses. I'll let you know once a decision is made. |
@xermicus |
@xermicus
this is to address issue #379
implementation test
cargo test -p resolc ipfscargo test -p revive-solc-json-interface ipfs