Open
Conversation
athei
reviewed
Apr 26, 2025
| To update the formula: | ||
|
|
||
| 1. Create a new release on GitHub | ||
| 2. Update the `url` and `sha256` in `Formula/resolc.rb` |
Member
There was a problem hiding this comment.
Stale comment? This should be handled by the github workflow?
Comment on lines
+8
to
+10
| # If someone wants to build from latest source: | ||
| head "https://github.com/paritytech/revive.git", branch: "master" | ||
| depends_on "llvm@18" => :build if build.head? # only needed when building from source |
Member
There was a problem hiding this comment.
This won't work because we need our custom LLVM in order to build resolc. So either remove or add a second Formula for our LLVM build. We also do binary releases of those in our repo.
|
|
||
| jobs: | ||
| update-formula: | ||
| runs-on: ubuntu-latest |
Member
There was a problem hiding this comment.
Suggested change
| runs-on: ubuntu-latest | |
| runs-on: ubuntu-24.04 |
We use fixed version by convention.
Comment on lines
+29
to
+32
| run: | | ||
| # Get the release version and SHA256 | ||
| VERSION=$(echo ${{ github.ref }} | sed 's/refs\/tags\/v//') | ||
| SHA256=$(curl -sL https://github.com/paritytech/revive/archive/refs/tags/v${VERSION}.tar.gz | shasum -a 256 | cut -d' ' -f1) |
Member
There was a problem hiding this comment.
We also do LLVM releases from this repo. So we need to detect this here and skip if it is a LLVM release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Homebrew Formula for Revive Solidity Compiler (resolc)
This PR adds a Homebrew Formula for the Revive Solidity Compiler (resolc), making it easily installable on macOS systems.
Changes
Formula/resolc.rbwith support for binary installationxattr -cInstallation
Once merged, users can install resolc using:
Notes
Testing
The Formula has been tested with the latest release (v0.1.0-dev.14) and includes a basic test to verify the installation.