Fix Bulletin allowance parsing#138
Merged
charlesHetterich merged 1 commit intomainfrom May 7, 2026
Merged
Conversation
Contributor
|
Dev build ready — try this branch: |
01d19a6 to
e3c587f
Compare
Contributor
E2E Test Pass · ✅ PASSTag:
Sentry traces: view spans for this run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
allowance - usedremaining quotatransactions_allowance/bytes_allowancesemantics, zero-usage allowance, over-consumed clamp, and rejecting legacy-shaped extentsVerification
pnpm vitest run src/utils/account/authorizationExtent.test.ts src/utils/account/allowance.test.ts src/utils/account/attestation.test.tsnpx tsc --noEmitpnpm testpnpm format:checkContext
The current Bulletin runtime reports
transactions/bytesas used quota andtransactions_allowance/bytes_allowanceas the granted totals. The CLI was treating the used counters as remaining quota, which caused active authorizations with zero usage to look exhausted during deploy preflight. This PR intentionally targets the current runtime shape only.