test(e2e): register fixtures with visibility=0 (private)#133
Merged
ottovlotto merged 1 commit intomainfrom May 6, 2026
Merged
Conversation
Mirrors the --private flag added in #114 to the bootstrap tool. Without this, re-running register-e2e-fixtures.ts re-publishes fixtures as PUBLIC and undoes the visibility flip, putting test traffic back into the playground.dot grid.
Contributor
|
Dev build ready — try this branch: |
Contributor
E2E Test Pass · ✅ PASSTag:
Sentry traces: view spans for this run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
isPrivate: truetopublishToPlaygroundintools/register-e2e-fixtures.tsso bootstrapped E2E fixtures land atvisibility=0on the registry contract.--privateflag added in test(e2e): tighten fake-passing assertions; add cold-start init smoke #114; without this, re-running the bootstrap tool re-publishes fixtures as PUBLIC and undoes the visibility flip.Why
PR #114 hid new test traffic but called out a residual cleanup: "the existing 9 visible entries need a one-off setVisibility flip." The bootstrap tool itself was the gap — every re-run re-publishes the 5 fixtures (
dot-cli-mod-fixture.dot,e2e-cli-foundry/cdm/hardhat/multi) at the defaultvisibility=1. With this patch, a single re-run flips them to private and any future bootstrap keeps them private.CLI tests that hit these domains use direct
getMetadataUriqueries (dot mod <domain>, registry-readback assertions) which are unaffected by visibility — so no test changes are needed.Test plan
bun tools/register-e2e-fixtures.tsonce with the SIGNER seed to flip the existing 5 fixtures to private.bun tools/list-registry-apps.ts(queries as a non-owner):dot-cli-mod-fixture.dotno longer appears.dot mod dot-cli-mod-fixture.dotworks regardless of visibility.No changeset required (tools/test-only change, no user-facing CLI behavior change).