refactor(modable): drop gh auto-create from --modable#125
Merged
UtkarshBhardwaj007 merged 2 commits intomainfrom May 6, 2026
Merged
refactor(modable): drop gh auto-create from --modable#125UtkarshBhardwaj007 merged 2 commits intomainfrom
UtkarshBhardwaj007 merged 2 commits intomainfrom
Conversation
The user is now responsible for setting up a public GitHub origin themselves; dot deploy --modable consumes the existing origin or fails with an actionable message. Removes the gh CLI dependency end-to-end: - modable preflight: read origin, validate public via HEAD on github.com HTML page, or hard-fail. Non-GitHub URLs now also hard-fail (dot mod only fetches from codeload.github.com). - DeployScreen: ModablePreflightStage simplified; new ModableErrorStage renders the formal warning inside a yellow Callout matching the phone banner, dismissed on enter/esc. - dot mod: createOptionalGitBaseline reduced to git init only; no baseline commit (avoids requiring user.name/user.email). - dot init: GitHub CLI toolchain step and gh auth advisory deleted. - Telemetry: isExpectedCliError regex updated for the new error wording. - Drops --repo-name flag and the validateRepoName helper.
Contributor
|
Dev build ready — try this branch: |
Contributor
E2E Test Pass · ✅ PASSTag:
Sentry traces: view spans for this run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dot deploy --modableno longer auto-creates a GitHub repo. The CLI reads an existing public GitHuboriginor fails with an actionable message; missingorigin, private repos, and non-GitHub URLs all hard-fail at preflight.ghCLI dependency is removed end-to-end:dot initno longer installs it, theisGhAuthenticatedadvisory is gone, and--repo-nameis dropped.dot modbaseline reduced togit initonly (no commit) so it never depends on globaluser.name/user.email.ModableErrorStagein the deploy TUI renders the formal warning inside a yellow Callout banner (matching the "check your phone" sign-request style) and exits cleanly on Enter/Esc.Why
Auto-creating a public repo on the user's GitHub account from a "deploy" command was a meaningful side effect, hard-required
gh+ an out-of-bandgh auth login(because Ink owns stdio), and the failure path already routed users back to their shell anyway. This bringsdotin line with how every other deploy CLI (Vercel, Netlify, fly.io) handles source publishing: the user sets up the repo themselves, the CLI consumes the result.Test plan
pnpm tsc --noEmitclean (verified locally).pnpm testclean — 483/483 passing locally.dot deploy --signer dev --suri //Alice --domain test --buildDir dist --playground --modableexits non-zero with the formal warning.git remote add origin https://gitlab.com/foo/bar): same hard-fail with the new "must use a public GitHub repository" error.repositoryandbranch.dot modagainst any modable app produces a directory with a.git/and an unborn HEAD (no baseline commit).dot initdoes not attempt to installghand does not show thegh auth loginadvisory.