feat(esapi): add missing TPM commands in integrity_collection_pcr#650
Open
hyperfinitism wants to merge 1 commit into
Open
feat(esapi): add missing TPM commands in integrity_collection_pcr#650hyperfinitism wants to merge 1 commit into
hyperfinitism wants to merge 1 commit into
Conversation
Added the following wrapper functions with integration tests for these commands: - pcr_event (ESAPI spec 11.3.52) - pcr_allocate (11.3.54) - pcr_set_auth_policy (11.3.55) - pcr_set_auth_value (11.3.56) swtpm (libtpms) does not support PCR_SetAuthPolicy or PCR_SetAuthValue; these commands return TPM_RC_VALUE. So their integration tests are marked #[ignore], and their doc examples are marked no_run. Signed-off-by: Takuma IMAMURA <209989118+hyperfinitism@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request implements the following Esys wrapper the following wrapper functions with integration tests for these commands:
pcr_event(ESAPI spec 11.3.52)pcr_allocate(11.3.54)pcr_set_auth_policy(11.3.55)pcr_set_auth_value(11.3.56)These were extracted from #625.
Limitation
swtpm(libtpms) does not supportPCR_SetAuthPolicyorPCR_SetAuthValue; these commands always returnTPM_RC_VALUE. So their integration tests are marked#[ignore], and their doc examples are markedno_run.Reference: https://github.com/stefanberger/libtpms/blob/521c51073fe6f7c56023db78e56961fcaf7906e8/src/tpm2/TPMCmd/Platform/src/PlatformPcr.c