Properly render gradients when strokeScaling = false#1822
Open
adroitwhiz wants to merge 2 commits intopaperjs:developfrom
Open
Properly render gradients when strokeScaling = false#1822adroitwhiz wants to merge 2 commits intopaperjs:developfrom
adroitwhiz wants to merge 2 commits intopaperjs:developfrom
Conversation
adroitwhiz
force-pushed
the
fix-gradient-stroke-scaling-upstream
branch
2 times, most recently
from
a190238 to
4bdd192
Compare
2 tasks
adroitwhiz
force-pushed
the
fix-gradient-stroke-scaling-upstream
branch
from
4bdd192 to
4d5a79e
Compare
lehni
force-pushed
the
develop
branch
2 times, most recently
from
39b63a1 to
b90a711
Compare
lehni
force-pushed
the
develop
branch
3 times, most recently
from
4a6bf6f to
0f4afc5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In order to render gradients properly when strokeScaling is set to false on their corresponding items, their points must be transformed by
strokeMatrix, which refers to the transformation matrix to be applied directly to the item's contents (path points, etc) as opposed to the canvas on which the item is drawn.Related issues
Checklist
npm run jshintpasses)