Skip to content

Conversation

@jbrockmendel
Copy link
Member

@jbrockmendel jbrockmendel commented Dec 8, 2025

Matching the Timestamp behavior. Part of #63275. Sits on top of #63301.

@jorisvandenbossche jorisvandenbossche added this to the 3.0 milestone Dec 10, 2025
@mroeschke mroeschke mentioned this pull request Dec 10, 2025
Copy link
Contributor

@divya1974 divya1974 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some points to consider:

  1. Confirm cast_from_unit accepts the new out_reso argument (or update it).
  2. Replace magic numeric bounds with named constants (or compute from datetime.timedelta.max/min) and add a short comment.
  3. Add tests that check very large integer Timedelta inputs for weeks/days/hours/minutes (overflow edges) and tests that NaT values stay preserved."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants