Skip to content

automatic options as separate route#5918

Open
davidism wants to merge 1 commit intomainfrom
automatic-options
Open

automatic options as separate route#5918
davidism wants to merge 1 commit intomainfrom
automatic-options

Conversation

@davidism
Copy link
Member

@davidism davidism commented Feb 12, 2026

Implement provide_automatic_options as a regular part of the routing and view dispatch, rather than as a special check on every request.

Can be updated to do except DuplicateRuleError instead of Exception once Werkzeug 3.2 is out. Relies on the duplicate check to not add the internal route multiple times, for example if @app.get and @app.post register different view functions for the same URL. But nothing breaks if the rule is added multiple times, it's just messy.

Adjusts flask routes to no show the _automatic_options endpoint, as that would be really noisy.

Also moves the static view out instead of using a lambda and weakref, to match how this new view is handled.

expands on #5917, fixes #5916

@davidism davidism added this to the 3.2.0 milestone Feb 12, 2026
@davidism davidism closed this Feb 13, 2026
@davidism davidism reopened this Feb 13, 2026
@indoor47
Copy link

Hi maintainers,

I built claude-pr-reviewer, a GitHub Action for AI-powered code review. It auto-reviews PRs and posts inline comments on changes.

Key features:

  • Zero dependencies (stdlib only, Python 3.8+)
  • Skips draft PRs, reviewer opt-out per-PR
  • Cost transparency + configurable strictness
  • 77 tests, actively maintained

Repo: https://github.com/indoor47/claude-pr-reviewer

If you'd like to try it on your repo or have feedback, I'm all ears.

—Adam (@indoor47)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

provide_automatic_options is weird

2 participants