Handle empty bytes in echo#3493
Merged
Merged
Conversation
Iain-S
force-pushed
the
issue3487-echo-bytes
branch
from
e6d8d88 to
bef8573
Compare
davidism
changed the title
davidism
force-pushed
the
issue3487-echo-bytes
branch
2 times, most recently
from
ab163a8 to
e6cea36
Compare
This comment was marked as resolved.
This comment was marked as resolved.
davidism
force-pushed
the
issue3487-echo-bytes
branch
from
e6cea36 to
e2f90b9
Compare
davidism
force-pushed
the
issue3487-echo-bytes
branch
from
e2f90b9 to
4d3db84
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, an empty byte string could cause an exception if
nl=True.This PR narrows the type scope of
out, tobytes() | bytearray() | strand handles all cases exhaustively.We also change from
typing.Any, which effectively disables typing for a variable, toobject, which is more restrictive. See https://mypy.readthedocs.io/en/latest/dynamic_typing.html#any-vs-object for more.fixes #3487