Skip to content

platform-dependent testing.CaptureMode type alias #3452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jorenham wants to merge 1 commit into
base: stable
Choose a base branch
from
+4 −1
Open

platform-dependent testing.CaptureMode type alias #3452

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/click/testing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,10 @@

from .core import Command

CaptureMode: t.TypeAlias = t.Literal["sys", "fd"]
if sys.platform == "win32":
Comment thread
kdeldycke marked this conversation as resolved.
CaptureMode: t.TypeAlias = t.Literal["sys"] # pyright: ignore[reportRedeclaration]
else:
CaptureMode: t.TypeAlias = t.Literal["sys", "fd"] # pyright: ignore[reportRedeclaration]
Comment on lines +25 to +28
Copy link
Copy Markdown
Collaborator

@AndreasBackx AndreasBackx May 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder how you would make pyright happy here... 🤔️ Anyhow, this should still be fine I believe.

Copy link
Copy Markdown
Contributor Author

@jorenham jorenham May 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no redeclaration because these branches are mutually exclusive. So I'd say that this is false positive error, i.e. a bug in pyright, justifying this # pyright: ignore

ExceptionInfo: t.TypeAlias = tuple[type[BaseException], BaseException, TracebackType]


Expand Down
Loading