add -dry-run option to aliases example#3231
Closed
MAHESHKANDELA wants to merge 3 commits intopallets:mainfrom
Closed
add -dry-run option to aliases example#3231MAHESHKANDELA wants to merge 3 commits intopallets:mainfrom
MAHESHKANDELA wants to merge 3 commits intopallets:mainfrom
Conversation
Author
|
Hi, thanks for taking a look at this PR. Thanks again! |
Member
|
Stop using LLMs to generate output at us. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
• Added a --dry-run flag to the alias command in examples/aliases/aliases.py to preview alias changes without writing the config file.
• Changed config writing to text mode with UTF-8 encoding for correct configparser behavior.
Behavior
• alias ALIAS CMD --config_file writes the alias mapping and prints confirmation.
• alias ALIAS CMD --config_file --dry-run prints what would change and exits without modifying the file.
Tests
• Added tests/test_examples_aliases.py covering write, dry-run no-write, and overwrite behavior.
• python -m pytest -q → 1322 passed, 22 skipped, 1 xfailed
Commits
• 17b8b5f Add dry-run option to aliases example
• 3b9eb0f Add tests for aliases dry-run behavior