Skip to content

Onclick fix6#2785

Open
samialfattani wants to merge 86 commits into
pallets-eco:masterfrom
samialfattani:onclick-fix6
Open

Onclick fix6#2785
samialfattani wants to merge 86 commits into
pallets-eco:masterfrom
samialfattani:onclick-fix6

Conversation

@samialfattani
Copy link
Copy Markdown
Contributor

@samialfattani samialfattani commented Feb 7, 2026

Fixes #2556

This PR has been rebased many times. I hope this time it will be easier to review and merge.

  • All onclick= codes are removed.
  • All javascript:void(0) codes are removed.
  • The optimal CSP policy is mentioned in the Docs.

@samialfattani samialfattani marked this pull request as ready for review February 7, 2026 16:20
Comment thread flask_admin/templates/bootstrap4/admin/model/modals/create.html Outdated
Comment thread flask_admin/templates/bootstrap4/admin/model/modals/create.html Outdated
Comment thread flask_admin/templates/bootstrap4/admin/model/inline_field_list.html Outdated
Comment thread flask_admin/templates/bootstrap4/admin/model/inline_form.html Outdated
Comment thread flask_admin/templates/bootstrap4/admin/model/inline_list_base.html
@ElLorans
Copy link
Copy Markdown
Contributor

ElLorans commented Mar 6, 2026

Does this impact the csp example? Why the .mo file?

samialfattani and others added 4 commits March 7, 2026 13:57
77 is just added by mistake

Co-authored-by: Lorenzo <lorenzo.cerreta@gmail.com>
noted

Co-authored-by: Lorenzo <lorenzo.cerreta@gmail.com>
….html


sorry for annoying

Co-authored-by: Lorenzo <lorenzo.cerreta@gmail.com>
ok

Co-authored-by: Lorenzo <lorenzo.cerreta@gmail.com>
@samialfattani
Copy link
Copy Markdown
Contributor Author

Does this impact the csp example? Why the .mo file?

what do you mean ?? i never change any .mo file in this PR !

@hasansezertasan
Copy link
Copy Markdown
Member

what do you mean ?? i never change any .mo file in this PR !

There seem to be a change in "flask_admin/translations/en/LC_MESSAGES/admin.mo" file.

@samialfattani
Copy link
Copy Markdown
Contributor Author

what do you mean ?? i never change any .mo file in this PR !

There seem to be a change in "flask_admin/translations/en/LC_MESSAGES/admin.mo" file.

it was a mistake, now the admin.mo is reverted from previouse commit

dependabot Bot and others added 3 commits April 22, 2026 08:53
…llets-eco#2878)

Bumps [python-dotenv](https://github.com/theskumar/python-dotenv) from 1.1.1 to 1.2.2.
- [Release notes](https://github.com/theskumar/python-dotenv/releases)
- [Changelog](https://github.com/theskumar/python-dotenv/blob/main/CHANGELOG.md)
- [Commits](theskumar/python-dotenv@v1.1.1...v1.2.2)

---
updated-dependencies:
- dependency-name: python-dotenv
  dependency-version: 1.2.2
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…blob_storage (pallets-eco#2879)

Bumps [python-dotenv](https://github.com/theskumar/python-dotenv) from 1.1.1 to 1.2.2.
- [Release notes](https://github.com/theskumar/python-dotenv/releases)
- [Changelog](https://github.com/theskumar/python-dotenv/blob/main/CHANGELOG.md)
- [Commits](theskumar/python-dotenv@v1.1.1...v1.2.2)

---
updated-dependencies:
- dependency-name: python-dotenv
  dependency-version: 1.2.2
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@samialfattani
Copy link
Copy Markdown
Contributor Author

it is ready for review now

ElLorans and others added 26 commits April 27, 2026 21:55
When setting `column_filters` on a model, you can write dot-notated
paths like 'author.account.email' to traverse relationships and reach a
leaf attribute.

But when instantiating Filter classes you can't do this and need to pass
a Column/InstrumentedAttribute directly. This makes it hard to traverse
deeper relationships when using Filters vs using flask-admin's string
resolution.

This patch makes it possible to pass string paths to Filters and handles
resolving all of the required joins in the same way as passing raw
strings to `column_filters`.

This change is backwards compatible.
…aths-in-filters

Support string column paths in filters
* persist the uv download cache between builds
* use the smaller python:3.10-slim (min version supported) in place of mcr.microsoft.com/devcontainers/python:3.12
* separate build (docker compose ... build app) from the run (uv run --no-sync pytest) adding --no-sync, so the container doesn't re-resolve dependencies at test time
Bumps [idna](https://github.com/kjd/idna) from 3.13 to 3.15.
- [Release notes](https://github.com/kjd/idna/releases)
- [Changelog](https://github.com/kjd/idna/blob/master/HISTORY.md)
- [Commits](kjd/idna@v3.13...v3.15)

---
updated-dependencies:
- dependency-name: idna
  dependency-version: '3.15'
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [urllib3](https://github.com/urllib3/urllib3) from 2.6.3 to 2.7.0.
- [Release notes](https://github.com/urllib3/urllib3/releases)
- [Changelog](https://github.com/urllib3/urllib3/blob/main/CHANGES.rst)
- [Commits](urllib3/urllib3@2.6.3...2.7.0)

---
updated-dependencies:
- dependency-name: urllib3
  dependency-version: 2.7.0
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Convert onclick scripts event listeners

7 participants