Skip to content

Usage generation fixes #1090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lbarcziova merged 3 commits into from
Jan 20, 2026
Merged

Usage generation fixes #1090

lbarcziova merged 3 commits into from
Jan 20, 2026

Conversation

@lbarcziova
Copy link
Member

@lbarcziova lbarcziova commented Jan 20, 2026

No description provided.

@lbarcziova
Add exception handling for graphs generation
99181a1
@lbarcziova
Ignore graph generation failure for deployment
a7c15d3 
Continue with deploying if the graphs generation fails.
@lbarcziova
Don't generate newer graphs during test deployment
3c2c902 
This makes the CI on PR dependent on Packit's API.
lbarcziova
lbarcziova commented Jan 20, 2026
View reviewed changes
.github/workflows/test-deploy.yml
- name: Import the nested docs
run: make import

- name: Generate newer usage graphs
Copy link
Member Author

@lbarcziova lbarcziova Jan 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or if we want to use it for testing the script, we can make it react only for changes on files/generate_usage.py path, wdyt?

Copy link
Member

@majamassarini majamassarini Jan 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

React to changes in the path can be helpful to catch errors earlier. But I am also fine with it like this. I expect we would catch the errors in the action were we really need this.

@centosinfra-prod-github-app
Copy link
Contributor

centosinfra-prod-github-app bot commented Jan 20, 2026

Build succeeded.
https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/packit-service/buildset/065b816f0042410babc3141e2458057d

✔️ pre-commit SUCCESS in 1m 03s

majamassarini
majamassarini approved these changes Jan 20, 2026
View reviewed changes
Copy link
Member

@majamassarini majamassarini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@lbarcziova lbarcziova added the mergeit Merge via Zuul label Jan 20, 2026
@centosinfra-prod-github-app
Copy link
Contributor

centosinfra-prod-github-app bot commented Jan 20, 2026

Build succeeded (gate pipeline).
https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/packit-service/buildset/c34b1dcbed12460f8c2483b4f9421704

✔️ pre-commit SUCCESS in 1m 04s

@centosinfra-prod-github-app
Copy link
Contributor

centosinfra-prod-github-app bot commented Jan 20, 2026

Pull request merge failed: Resource not accessible by integration, You may need to manually rebase your PR and retry.

@lbarcziova lbarcziova merged commit 17bba63 into packit:main Jan 20, 2026
6 checks passed
@github-project-automation github-project-automation bot moved this from New to Done in Packit pull requests Jan 20, 2026
@lbarcziova lbarcziova deleted the usage-generation-fixes branch January 20, 2026 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@majamassarini majamassarini majamassarini approved these changes

Assignees

No one assigned

Labels

mergeit Merge via Zuul

Projects

Packit pull requests
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lbarcziova @majamassarini