Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #298 +/- ##
==========================================
+ Coverage 71.59% 71.71% +0.11%
==========================================
Files 204 204
Lines 14770 14839 +69
==========================================
+ Hits 10575 10642 +67
- Misses 3441 3442 +1
- Partials 754 755 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cheb0
force-pushed
the
295-unique-count
branch
3 times, most recently
from
6b82090 to
10737f2
Compare
cheb0
force-pushed
the
295-unique-count
branch
from
2ed2787 to
025ec18
Compare
cheb0
force-pushed
the
295-unique-count
branch
from
db9b3a3 to
5bb3020
Compare
| } | ||
| if errMessage == consts.ErrTooManyFieldValues.Error() { | ||
| return nil, source, fmt.Errorf("store forbids aggregation request: %w", consts.ErrTooManyFieldValues) | ||
| } |
There was a problem hiding this comment.
we need to check new resp.Code later as well. on line 614-625
| aggs[i] = seq.AggregatableSamples{ | ||
| SamplesByBin: to, | ||
| NotExists: agg.NotExists, | ||
| ValuesPool: stringPool, |
There was a problem hiding this comment.
nit: seem like we can just do ValuesPool: agg.ValuesPool, and remove stringPool variable
| } | ||
| for idx := range hist.Values { | ||
| h.Values[idx] = struct{}{} | ||
| } |
There was a problem hiding this comment.
nit: seems like we can use maps.Copy here
| q.SamplesByBin = make(map[AggBin]*SamplesContainer, len(agg.SamplesByBin)) | ||
| } | ||
|
|
||
| oldToNewIndexMap := make(map[uint32]uint32, len(agg.ValuesPool)) |
There was a problem hiding this comment.
nit: Could we use a slice instead of a map here? (It would likely perform better)
🔴 Performance DegradationSome benchmarks have degraded compared to the previous run. Show table
|
4 participants
Description
Fixes #295