Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #278 +/- ##
==========================================
- Coverage 71.16% 71.07% -0.09%
==========================================
Files 201 201
Lines 14773 14823 +50
==========================================
+ Hits 10513 10536 +23
- Misses 3515 3536 +21
- Partials 745 751 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
forshev
approved these changes
Dec 2, 2025
| for i, doc := range docs { | ||
| docID := qpr.IDs[i].ID.String() | ||
| if fetchedIDs[docID] == true { | ||
| fmt.Println("bro") |
Contributor
There was a problem hiding this comment.
seems like missed debug print
# Conflicts: # proxy/search/search_request.go # storeapi/grpc_search.go
dkharms
reviewed
Jan 12, 2026
dkharms
approved these changes
Jan 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A new way to paginate through logs which is similar to Elasticsearch
search_afterfeature. A user can take doc ID from the last doc on the page and use it as offset for the next page. The field is calledoffset-id: the first partoffsetoutlines that it provides offset feature, the partidpoints that it's a doc ID.Measurements
Our benchmarks
seq-db-paging.js
seq-db-offset-id.js (new)
Elasticsearch
Currently, it's unable to cope with 20 concurrent readers (all CPU is used) but even with a single reader it's slow. Will investigate later.
Results for other data
k8s_pod:payment-backend-* AND level:4, scroll 50 pages 100 logs each (cold run after seq-db restart)
2114 ms (offset) vs 1729 ms (offset-id)
k8s_pod:payment-backend-1 AND level:2, scroll 50 pages 100 logs each (cold run after seq-db restart)
468 ms (offset) vs 166 ms (offset-id)
Fixes #262
If you have used LLM/AI assistance please provide model name and full prompt: