Skip to content

Extract some testing constants into textFixtures #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pemulis merged 3 commits into from
Nov 4, 2025
Merged

Extract some testing constants into textFixtures #54

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
872c3a0
extract constants from deposits test into fixtures file
dkuthoore Nov 3, 2025
c4cfebe
format fix
dkuthoore Nov 3, 2025
ca3ef24
extract intention from validator test
dkuthoore Nov 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
82 changes: 82 additions & 0 deletions test/helpers/testFixtures.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@
* Shared test data and constants used across test suites.
*/

import type { Intention } from '../../src/types/core.js'

/**
* Sample vault ID for testing (valid 32-byte hex string with 0x prefix).
*/
Expand Down Expand Up @@ -72,3 +74,83 @@ export const SAMPLE_INTENTION = {
vaultId: TEST_VAULT_ID,
signature: '0x' + '0'.repeat(130), // Dummy signature
}

/**
* Test transaction hash for deposits tests.
*/
export const TEST_TX = '0xtest-deposit-tx'

/**
* Generate test UID for deposits tests.
*/
export const TEST_UID = (n: number) => `${TEST_TX}:${n}`

/**
* Controller address for deposits tests.
*/
export const CTRL = '0xCcCcCcCcCcCcCcCcCcCcCcCcCcCcCcCcCcCcCcCc'

/**
* Token address for deposits tests.
*/
export const TOKEN = '0x1111111111111111111111111111111111111111'

/**
* Zero address (ETH address).
*/
export const ZERO = '0x0000000000000000000000000000000000000000'

/**
* Creates a mock valid intention object for testing.
* Returns a new intention object each time it's called with a fresh expiry timestamp.
*/
export const createMockValidIntention = (): Intention => ({
action: 'Swap 1,000 USDC for 0.3 WETH with .016 WETH in fees',
nonce: 1,
expiry: Math.floor(Date.now() / 1000) + 3600, // Expires in 1 hour
inputs: [
{
asset: '0xA0b86991c6218b36c1d19D4a2e9Eb0cE3606eB48', // USDC
amount: '1000.0',
chain_id: 1,
},
],
outputs: [
{
asset: '0xC02aaA39b223FE8D0A0e5C4F27eAD9083C756Cc2', // WETH
amount: '0.3',
to_external: '0xDB473D9716ac61dc4D4aeA6e4d691239DB84C77D',
chain_id: 1,
},
],
totalFee: [
{
asset: ['WETH'],
amount: '0.016',
},
],
proposerTip: [
{
asset: '0xC02aaA39b223FE8D0A0e5C4F27eAD9083C756Cc2', // WETH
amount: '0.01',
to: 123, // Some vault ID
chain_id: 1,
},
],
agentTip: [
{
asset: '0xC02aaA39b223FE8D0A0e5C4F27eAD9083C756Cc2', // WETH
amount: '0.005',
to: 456, // Some other vault ID
chain_id: 1,
},
],
protocolFee: [
{
asset: '0xC02aaA39b223FE8D0A0e5C4F27eAD9083C756Cc2', // WETH
amount: '0.001',
to: 0, // Oya vault ID
chain_id: 1,
},
],
})
13 changes: 7 additions & 6 deletions test/integration/deposits.db.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,12 +17,13 @@ import {
findDepositWithSufficientRemaining,
createAssignmentEventTransactional,
} from '../../src/utils/deposits.js'

const TEST_TX = '0xtest-deposit-tx'
const TEST_UID = (n: number) => `${TEST_TX}:${n}`
const CTRL = '0xCcCcCcCcCcCcCcCcCcCcCcCcCcCcCcCcCcCcCcCc'
const TOKEN = '0x1111111111111111111111111111111111111111'
const ZERO = '0x0000000000000000000000000000000000000000'
import {
TEST_TX,
TEST_UID,
CTRL,
TOKEN,
ZERO,
} from '../helpers/testFixtures.js'

beforeAll(async () => {
await pool.query('DELETE FROM deposits WHERE tx_hash = $1', [TEST_TX])
Expand Down
52 changes: 2 additions & 50 deletions test/validator.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,59 +20,11 @@ import {
ValidationError,
} from '../src/utils/validator.js'
import type { Intention } from '../src/types/core.js'
import { createMockValidIntention } from './helpers/testFixtures.js'

// --- MOCK DATA FOR TESTS ---

const mockValidIntention: Intention = {
action: 'Swap 1,000 USDC for 0.3 WETH with .016 WETH in fees',
nonce: 1,
expiry: Math.floor(Date.now() / 1000) + 3600, // Expires in 1 hour
inputs: [
{
asset: '0xA0b86991c6218b36c1d19D4a2e9Eb0cE3606eB48', // USDC
amount: '1000.0',
chain_id: 1,
},
],
outputs: [
{
asset: '0xC02aaA39b223FE8D0A0e5C4F27eAD9083C756Cc2', // WETH
amount: '0.3',
to_external: '0xDB473D9716ac61dc4D4aeA6e4d691239DB84C77D',
chain_id: 1,
},
],
totalFee: [
{
asset: ['WETH'],
amount: '0.016',
},
],
proposerTip: [
{
asset: '0xC02aaA39b223FE8D0A0e5C4F27eAD9083C756Cc2', // WETH
amount: '0.01',
to: 123, // Some vault ID
chain_id: 1,
},
],
agentTip: [
{
asset: '0xC02aaA39b223FE8D0A0e5C4F27eAD9083C756Cc2', // WETH
amount: '0.005',
to: 456, // Some other vault ID
chain_id: 1,
},
],
protocolFee: [
{
asset: '0xC02aaA39b223FE8D0A0e5C4F27eAD9083C756Cc2', // WETH
amount: '0.001',
to: 0, // Oya vault ID
chain_id: 1,
},
],
}
const mockValidIntention: Intention = createMockValidIntention()

// --- TEST SUITES ---

Expand Down