Skip to content

fix!: require title when definitions are empty #963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ericszentivanyi wants to merge 5 commits into
base: main
Choose a base branch
from
Open

fix!: require title when definitions are empty #963

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c2e2c73
fix!: require title when there are no definitions in the schema
ericszentivanyi Jan 14, 2026
843da74
chore: rename `show_type_name`
ericszentivanyi Jan 14, 2026
7edf810
chore: introduce `InvalidRootSchema` error
ericszentivanyi Jan 14, 2026
9e665fa
chore: create a `title` variable
ericszentivanyi Jan 14, 2026
b9d9ccc
docs: restore comment
ericszentivanyi Jan 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions typify-impl/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,8 @@ pub enum Error {
type_name: Option<String>,
reason: String,
},
#[error("invalid root schema: {reason}")]
InvalidRootSchema { reason: String },
}

impl Error {
Expand Down Expand Up @@ -790,17 +792,21 @@ impl TypeSpace {
definitions,
} = schema;

let title = schema.metadata.as_ref().and_then(|m| m.title.as_ref());

if definitions.is_empty() && title.is_none() {
return Err(Error::InvalidRootSchema {
reason: "title is required when there are no definitions".to_string(),
});
}

let mut defs = definitions
.into_iter()
.map(|(key, schema)| (RefKey::Def(key), schema))
.collect::<Vec<_>>();

// Does the root type have a name (otherwise... ignore it)
let root_type = schema
.metadata
.as_ref()
.and_then(|m| m.title.as_ref())
.is_some();
let root_type = title.is_some();

if root_type {
defs.push((RefKey::Root, schema.into()));
Expand Down