run header-check in CI #1017
Merged
run header-check in CI #1017
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iximeow
force-pushed
the
ixi/check-headers-in-ci
branch
from
62e9a3a to
adba59f
Compare
iximeow
force-pushed
the
ixi/check-headers-in-ci
branch
from
adba59f to
b4978bf
Compare
Member
Author
with similar blocks for nvpair and viona-api. and with this I ought to go add a header-check for the new |
jordanhendricks
approved these changes
Jan 14, 2026
Contributor
jordanhendricks
left a comment
jordanhendricks
left a comment
There was a problem hiding this comment.
this is awesome! i have definitely wished for it before!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
motivated by #1015, wherein I didn't pay close enough attention to the viona header changes because I thought header-check had run in CI and confirmed that they lined up. so, lets make that true.
this comes at the cost of one unfortunate-ish clone of illumos-gate per Propolis CI run, but that's not.. the worst thing, maybe?
git clone --depth 1 --branch stlouis https://code.oxide.computer/illumos-gateyields about 500 MiB of stuff, though i'm not sure how much that was on the network.@jclulow had suggested we could grab this from CTF, or headers from helios packages, and i think that's a good option particularly when we're comparing against
stlouis. but i hope that if we find ourselves working on changes like #998 we'd nudgeGATE_REFappropriately until OS changes are integrated alongside Propolis. in that case we'd need to be grabbing development headers out of git all the same, so here we are.