Skip to content

Conversation

@citrus-it
Copy link
Contributor

No description provided.

@citrus-it citrus-it marked this pull request as ready for review January 8, 2026 22:00
Copy link
Contributor

@dancrossnyc dancrossnyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've been using this quite a bit for some time to debug the multiqueue implementation as we've been developing it. It's been very valuable, and works well.

Copy link
Member

@iximeow iximeow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! noticed a few things, but clearly this is useful as-is.

Comment on lines +246 to +249
viona_ioctl:return/self->cmd != 0 && arg1 != 0/ {
printf("ioctl(%s) returning 0x%x\n", self->cmd, arg1);
self->cmd = 0;
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might be interesting to print errno if arg1 == -1 yeah? presumably you have not had to care about that in working on multiqueue :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the event of an error, arg1 is actually the error number here.

@morlandi7 morlandi7 added this to the 18 milestone Jan 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants