Bump clickhouse to latest patch.#10431
Open
jmcarp wants to merge 1 commit into
Open
Conversation
We found in oxidecomputer/customer-support#1101 that clickhouse runs a huge number of thread renames, which consure the majority of cpu time on some workloads. Since we don't need the debugging feature that this renaming supports, we patched out os-level thread renames in oxidecomputer/garbage-compactor#33. This patch updates omicron to fetch the latest clickhouse archive from s3. Note that we also introduce a hash-based suffix to the clickhouse version to represent changes in oxide-specific patches applied to the clickhouse source version. Note that we also merged a more principled fix into upstream clickhouse for this issue: ClickHouse/ClickHouse#104410. Once we upgrade to a current clickhouse version, we'll drop the patch in garbage-compactor. h/t as usual @wfchandler and @JustinAzoff for the investigation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We found in https://github.com/oxidecomputer/customer-support/issues/1101 that clickhouse runs a huge number of thread renames, which consure the majority of cpu time on some workloads. Since we don't need the debugging feature that this renaming supports, we patched out os-level thread renames in oxidecomputer/garbage-compactor#33. This patch updates omicron to fetch the latest clickhouse archive from s3. Note that we also introduce a hash-based suffix to the clickhouse version to represent changes in oxide-specific patches applied to the clickhouse source version.
Note that we also merged a more principled fix into upstream clickhouse for this issue: ClickHouse/ClickHouse#104410. Once we upgrade to a current clickhouse version, we'll drop the patch in garbage-compactor.
h/t as usual @wfchandler and @JustinAzoff for the investigation.