Improve error reporting when omdb tries to fetch the inventory for a collection that doesn't exist#10430
Open
piffio wants to merge 2 commits intooxidecomputer:mainfrom
Conversation
Add a failing test to reproduce the issue reported in oxidecomputer#8336. We expect an error informing that collection is missing rather than a generic failure.
Discriminate different return cases when fetching a collection: * Found -> Return the collection * Not found -> Return an ObjectNotFound error * Multiple entries found -> Return a generic error, as this is unexpected behaviour
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This simple PR adds a three-way discrimination for handling the return value when trying to fetch a specific collection from CockroachDB.
Fixes #8336
@davepacheco I am not sure if, for case 3, multiple entries found, it would be better to return a specific error informing of the unexpected state. I lack enough context to understand how unlikely that possibility is.