Remove Port{Fec,Speed} in favor of Link{Fec,Speed}#10417
Open
jgallagher wants to merge 3 commits intomainfrom
Open
Remove Port{Fec,Speed} in favor of Link{Fec,Speed}#10417jgallagher wants to merge 3 commits intomainfrom
Port{Fec,Speed} in favor of Link{Fec,Speed}#10417jgallagher wants to merge 3 commits intomainfrom
Conversation
ahl
approved these changes
May 8, 2026
Contributor
ahl
left a comment
ahl
left a comment
There was a problem hiding this comment.
love it; thanks! sorry for the drift shenanigans!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to this PR, we had both
PortFec+LinkFecandPortSpeed+LinkSpeed(both pairs of enums that were identical except for their names and doc comments). Per @rcgoodfellow in chat,Link*is a more accurate name, so this PR keeps that one and removes thePort*enums.LinkFec/LinkSpeedwere already used in the Nexus external API, so that one doesn't change at all. A bunch of internal APIs were using thePort*version, so those had a lot of wire-compatible churn to include the new docstrings. The diff stat here ignoring OpenAPI spec churn is+142, -219(net negative from removing the duplicate types and associatedFromimpls).This was originally part of #10344, but was deferred to wait for some
driftfixes, all of which have now landed, courtesy of @ahl and @sunshowers. Closes #10403.