[4/3] Place SP task dumps under sp_task_dumps/ in support bundles#10411
Open
smklein wants to merge 1 commit intoomdb-support-bundle-collectfrom
Open
[4/3] Place SP task dumps under sp_task_dumps/ in support bundles#10411smklein wants to merge 1 commit intoomdb-support-bundle-collectfrom
sp_task_dumps/ in support bundles#10411smklein wants to merge 1 commit intoomdb-support-bundle-collectfrom
Conversation
`spawn_collection_steps` creates an `sp_task_dumps/` directory in the
bundle root, but the per-SP closure it spawned captured the framework's
outer `dir` (the bundle root) instead of the subdirectory. As a result
the dumps landed at `<root>/sled_0/dump-0.zip`, `<root>/switch_0/...`,
etc., while `sp_task_dumps/` was created and left empty.
Capture `sp_dumps_dir` into the spawned closure so dumps land at
`sp_task_dumps/{sp.type}_{sp.slot}/dump-{i}.zip` as the surrounding
code intended.
smklein
force-pushed
the
omdb-support-bundle-collect
branch
from
b26398c to
d180d48
Compare
smklein
force-pushed
the
fix-sp-task-dumps-location
branch
from
06786a0 to
8c1006c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While I was working on #10376, I noticed that SP dumps were being placed in the top-level directory of the bundle, not within the intended subdirectory.
This PR fixes that issue.