[ip-pool] block silo unlinking when multicast groups are allocated from the pool#10404
Open
zeeshanlakhani wants to merge 1 commit intomainfrom
Open
[ip-pool] block silo unlinking when multicast groups are allocated from the pool#10404zeeshanlakhani wants to merge 1 commit intomainfrom
zeeshanlakhani wants to merge 1 commit intomainfrom
Conversation
…om the pool Fixes the issue found in #10304: > P2-13 (novel): unlink_ip_pool_from_external_silo_query does not check multicast_group for outstanding rows. > Purely missing from the guard not a race. A non-racy DELETE /v1/system/ip-pools/{pool}/silos/{silo} can > unlink a silo's multicast pool even when the silo has live multicast groups allocated. Predates the multicast > feature, so Some IP Pool database operations may not be concurrency-safe #8992 doesn't cover it. This adds a `multicast_groups` CTE to the guard, mirroring the existing multicast check in `ip_pool_delete_range`.
zeeshanlakhani
force-pushed
the
zl/ip-pool-unlink-multicast-guard
branch
from
049a0a1 to
234fc88
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the issue found in #10304:
This adds a
multicast_groupsCTE to the guard, mirroring the existing multicast check inip_pool_delete_range.