bump to opte version 41, add v4 over v6 static routes#743
Open
rcgoodfellow wants to merge 6 commits into
Open
Conversation
Contributor
|
Looks good to me overall. I asked claude to do a quick spotcheck and it had a couple bits of feedback on the CI script.
|
2 tasks
taspelund
reviewed
May 27, 2026
Comment on lines
+36
to
+37
| #[path = "v4_over_v6_static_routes/mod.rs"] | ||
| pub mod v10; |
Contributor
There was a problem hiding this comment.
Is cargo fmt sorting this in lexicographical order instead of numerical? or can we adjust to use numerical order for readability?
taspelund
approved these changes
May 27, 2026
Contributor
taspelund
left a comment
There was a problem hiding this comment.
v4 over v6 work looks clean to me. only one nit about module sorting order in mg-api-types, but I'm not feeling overly motivated to fight rustfmt/cargo fmt if it's not a simple change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OPTE Version Bump
OPTE version bump to go along with:
Fix Omicron Dependency Loop
PR #720 introduced a dependency from
mg-admin-clienttomg-commonwhich depends on a large number of omicron crates. Since omicron importsmg-admin-clientthis creates a dependency mess in omicron. So I'm cutting off the dependency here and adding a CI test that ensures none of the client or API type crates can depend on omicron.Also adds a CI script to ensure that an omicron dependency loop does not creep back in.
Support for Static IPv4 Routes Over IPv6 Nexthops
This was an oversight in the initial IPv4 over IPv6 routing support.