Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
david-crespo
force-pushed
the
external-subnets-ui
branch
from
e865ae2 to
9d8bc0f
Compare
david-crespo
force-pushed
the
external-subnets-ui
branch
from
9d8bc0f to
cf41314
Compare
|
Great! I don't see any grave UI crimes, but I'll take a look later. We have a subnet icon already too. |
Extracted from external subnets work coming in #3039 but not present yet in that PR.
david-crespo
force-pushed
the
external-subnets-ui
branch
from
b5b8591 to
1870627
Compare
david-crespo
force-pushed
the
external-subnets-ui
branch
from
1870627 to
d7a392a
Compare
david-crespo
force-pushed
the
external-subnets-ui
branch
from
d7a392a to
a1b7e58
Compare
david-crespo
force-pushed
the
external-subnets-ui
branch
from
a1b7e58 to
508542b
Compare
david-crespo
force-pushed
the
external-subnets-ui
branch
from
508542b to
28f7e4f
Compare
david-crespo
force-pushed
the
external-subnets-ui
branch
from
28f7e4f to
12b1a30
Compare
david-crespo
force-pushed
the
external-subnets-ui
branch
from
12b1a30 to
2b6ca12
Compare
david-crespo
force-pushed
the
external-subnets-ui
branch
from
2b6ca12 to
5ec48fa
Compare
| } | ||
|
|
||
| /** Format a pool for use as a ListboxField item */ | ||
| export function toPoolItem(p: PoolLike): ListboxItem { |
There was a problem hiding this comment.
We love TypeScript.
david-crespo
force-pushed
the
external-subnets-ui
branch
from
5ec48fa to
85b8cf8
Compare
app/forms/external-subnet-create.tsx
Outdated
| min={8} | ||
| max={32} | ||
| description="The prefix length for the allocated subnet (e.g., 24 for a /24). Minimum 8." | ||
| /> |
There was a problem hiding this comment.
Appropriate validation here is an open question, looking into it. Claude analysis of current validation on the server and what subset we might do on the client:
https://gist.github.com/david-crespo/f08d9b4cb7cdcd3fec1e9c46aad11bed
|
Nice error from the API on dogfood. Will make a note to fix the casing, though. 
|
charliepark
left a comment
charliepark
left a comment
There was a problem hiding this comment.
This looks good. I wondered if changing the existing subnets tab in the VPC view toVPC subnets might help distinguish between them and the external subnets, but I think it's probably fine without that.
Running locally, everything else seemed fine.
|
Good idea, I will do that. |
Suggestion from @charliepark in #3039 (review). Decided to make it a separate PR because it came out to 70 lines of changes.
3 participants
Closes #3030
Closes #3031
Operator subnet pools UI is in #3146.