Workaround new window LTI launches. #53
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When launching a LTI tool in a new window directly from Canvas it will not have a window.opener set because Canvas launches the new window to it's own URL (https://canvas.instructure.com...) which then redirects to the tool. Browsers block the window.opener property if it doesn't match the domain that the new window was opened with and in this case a LTI tool will be on a different domain. This doesn't introduce a security issue because the checking of state is done in step 3 and if it was successfully set by a cookie the LTI launch will continue without a problem, but it does remove the pause that is seen when we don't have a valid window to send our post messages to.
buckett
requested review from
Copilot,
nicholaswilson100 and
sebastianchristopher
There was a problem hiding this comment.
Pull Request Overview
This PR provides a workaround for handling LTI launches opened in a new window from Canvas where window.opener is not set.
- Added a check for when the current window is the only available target frame.
- Logs a message and redirects the window to the intended URL, relying on cookies as a fallback.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When launching a LTI tool in a new window directly from Canvas it will not have a window.opener set because Canvas launches the new window to it's own URL (https://canvas.instructure.com...) which then redirects to the tool. Browsers block the window.opener property if it doesn't match the domain that the new window was opened with and in this case a LTI tool will be on a different domain.
This doesn't introduce a security issue because the checking of state is done in step 3 and if it was successfully set by a cookie the LTI launch will continue without a problem, but it does remove the pause that is seen when we don't have a valid window to send our post messages to.