Skip to content

Conversation

@lardo-de-arnaud
Copy link
Contributor

… to be done in the LTI tool

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new utility function getTestUrl() to the deployment-test-utils package, which constructs and exports the full test path URL from environment variables CANVAS_HOST and DEPLOYMENT_TEST_PATH. This eliminates the need for consuming LTI tools to manually construct URLs, simplifying test setup.

Key Changes:

  • Added URL normalization logic that trims whitespace and handles trailing/leading slashes consistently
  • Exported a new getTestUrl() function that returns the pre-computed URL or undefined if the host is not set

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

lardo-de-arnaud and others added 2 commits November 14, 2025 13:20
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@sebastianchristopher
Copy link
Contributor

I wonder whether it's worth writing these back to process.env for the runtime duration - that way you can still import process.env.CANVAS_HOST into tests and it will be normalized?

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@lardo-de-arnaud lardo-de-arnaud merged commit 3b9449d into master Nov 14, 2025
7 checks passed
@lardo-de-arnaud lardo-de-arnaud deleted the AB#107240 branch November 14, 2025 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants