Skip to content

[tests-only][full-ci] Make the parameter value const and type check #13588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nabim777 wants to merge 3 commits into
base: master
Choose a base branch
from
Open

[tests-only][full-ci] Make the parameter value const and type check #13588

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dc15a06
tests: make parameter constant
nabim777 Apr 7, 2026
60108a1
tests: type check
nabim777 Apr 8, 2026
59b5674
tests: rename allfiles to allFiles
nabim777 Apr 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions tests/e2e-playwright/specs/admin-settings/groups.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import { test } from '../../support/test'
import * as ui from '../../steps/ui/index'
import * as api from '../../steps/api/api'
import { actions } from '../../support/constants'

test.describe('groups management', () => {
test.beforeEach(async ({ world }) => {
Expand Down Expand Up @@ -37,7 +38,7 @@ test.describe('groups management', () => {
await ui.userDeletesGroups({
world,
stepUser: 'Admin',
actionType: 'context menu',
actionType: actions.contextMenu,
groupsToBeDeleted: ['sales']
})

Expand All @@ -50,7 +51,7 @@ test.describe('groups management', () => {
await ui.userDeletesGroups({
world,
stepUser: 'Admin',
actionType: 'batch actions',
actionType: actions.batchAction,
groupsToBeDeleted: ['security', 'finance']
})

Expand All @@ -75,7 +76,7 @@ test.describe('groups management', () => {
key: 'sales',
attribute: 'displayName',
value: 'a renamed group',
action: 'context-menu'
action: actions.contextMenu
})
await ui.userShouldSeeGroupDisplayName({
world,
Expand Down
3 changes: 2 additions & 1 deletion tests/e2e-playwright/specs/app-provider/lock.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import { test } from '../../support/test'
import * as api from '../../steps/api/api'
import * as ui from '../../steps/ui/index'
import { applications } from '../../support/constants'

test.describe('lock', { tag: '@sse' }, () => {
test.beforeEach(async ({ world }) => {
Expand Down Expand Up @@ -54,7 +55,7 @@ test.describe('lock', { tag: '@sse' }, () => {
world,
stepUser: 'Brian',
resource: 'test.odt',
application: 'Collabora'
application: applications.collabora
})
// Then "Brian" should see the content "some content" in editor "Collabora"
await ui.userShouldSeeContentInEditor({
Expand Down
35 changes: 18 additions & 17 deletions tests/e2e-playwright/specs/app-provider/officeSuites.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
import { test } from '../../support/test'
import * as api from '../../steps/api/api'
import * as ui from '../../steps/ui/index'
import { actions, applications, displayedResources } from '../../support/constants'

test.describe('Integrate with online office suites like Collabora and OnlyOffice', () => {
test.beforeEach(async ({ world }) => {
Expand Down Expand Up @@ -53,7 +54,7 @@ test.describe('Integrate with online office suites like Collabora and OnlyOffice
world,
stepUser: 'Alice',
resource: 'OpenDocument.odt',
application: 'Collabora'
application: applications.collabora
})

// And "Anonymous" opens the public link "Unnamed link"
Expand Down Expand Up @@ -163,7 +164,7 @@ test.describe('Integrate with online office suites like Collabora and OnlyOffice
await ui.userSharesResources({
world,
stepUser: 'Alice',
actionType: 'SIDEBAR_PANEL',
actionType: actions.sideBarPanel,
shares: [
{
resource: 'OpenDocument.odt',
Expand All @@ -188,7 +189,7 @@ test.describe('Integrate with online office suites like Collabora and OnlyOffice
world,
stepUser: 'Brian',
resource: 'OpenDocument.odt',
application: 'Collabora'
application: applications.collabora
})

// Then "Brian" should not be able to edit content of following resource
Expand Down Expand Up @@ -225,7 +226,7 @@ test.describe('Integrate with online office suites like Collabora and OnlyOffice
world,
stepUser: 'Alice',
resource: 'OpenDocument.odt',
application: 'Collabora'
application: applications.collabora
})

// And "Brian" opens the following file in Collabora
Expand All @@ -235,7 +236,7 @@ test.describe('Integrate with online office suites like Collabora and OnlyOffice
world,
stepUser: 'Brian',
resource: 'OpenDocument.odt',
application: 'Collabora'
application: applications.collabora
})

// And "Alice" edits the following resource
Expand Down Expand Up @@ -335,7 +336,7 @@ test.describe('Integrate with online office suites like Collabora and OnlyOffice
world,
stepUser: 'Alice',
resource: 'MicrosoftWord.docx',
application: 'OnlyOffice'
application: applications.onlyOffice
})

// And "Anonymous" opens the public link "Unnamed link"
Expand Down Expand Up @@ -460,7 +461,7 @@ test.describe('Integrate with online office suites like Collabora and OnlyOffice
await ui.userSharesResources({
world,
stepUser: 'Alice',
actionType: 'SIDEBAR_PANEL',
actionType: actions.sideBarPanel,
shares: [
{
resource: 'MicrosoftWord.docx',
Expand All @@ -485,7 +486,7 @@ test.describe('Integrate with online office suites like Collabora and OnlyOffice
world,
stepUser: 'Brian',
resource: 'MicrosoftWord.docx',
application: 'OnlyOffice'
application: applications.onlyOffice
})

// Then "Brian" should not be able to edit content of following resource
Expand Down Expand Up @@ -526,7 +527,7 @@ test.describe('Integrate with online office suites like Collabora and OnlyOffice
world,
stepUser: 'Alice',
resource: 'MicrosoftWord.docx',
application: 'OnlyOffice'
application: applications.onlyOffice
})

// And "Brian" opens the following file in OnlyOffice
Expand All @@ -536,7 +537,7 @@ test.describe('Integrate with online office suites like Collabora and OnlyOffice
world,
stepUser: 'Brian',
resource: 'MicrosoftWord.docx',
application: 'OnlyOffice'
application: applications.onlyOffice
})

// And "Alice" edits the following resource
Expand Down Expand Up @@ -731,7 +732,7 @@ test.describe('Integrate with online office suites like Collabora and OnlyOffice
world,
stepUser: 'Alice',
resource: 'usingSpaceLink.docx',
application: 'OnlyOffice'
application: applications.onlyOffice
})

// Then "Alice" should see the content "public can create files in the project space using spaceLink" in editor "OnlyOffice"
Expand Down Expand Up @@ -762,7 +763,7 @@ test.describe('Integrate with online office suites like Collabora and OnlyOffice
world,
stepUser: 'Alice',
resource: 'usingFolderLink.docx',
application: 'OnlyOffice'
application: applications.onlyOffice
})

// Then "Alice" should see the content "Microsoft Word Content" in editor "OnlyOffice"
Expand Down Expand Up @@ -908,7 +909,7 @@ test.describe('Integrate with online office suites like Collabora and OnlyOffice
world,
stepUser: 'Alice',
resource: 'usingSpaceLink.odt',
application: 'Collabora'
application: applications.collabora
})

// Then "Alice" should see the content "public can create files in the project space using spaceLink" in editor "Collabora"
Expand All @@ -932,7 +933,7 @@ test.describe('Integrate with online office suites like Collabora and OnlyOffice
world,
stepUser: 'Alice',
resource: 'usingFolderLink.odt',
application: 'Collabora'
application: applications.collabora
})

// Then "Alice" should see the content "OpenDocument Content" in editor "Collabora"
Expand Down Expand Up @@ -970,7 +971,7 @@ test.describe('Integrate with online office suites like Collabora and OnlyOffice
stepUser: 'Alice',
file: 'Template.dotx',
webOffice: 'OnlyOffice',
actionType: 'sidebar panel'
actionType: actions.sideBarPanel
})

// Then "Alice" should see the content "As a user I want to create a document by clicking on a template file" in editor "OnlyOffice"
Expand All @@ -990,7 +991,7 @@ test.describe('Integrate with online office suites like Collabora and OnlyOffice
stepUser: 'Alice',
file: 'Template.ott',
webOffice: 'Collabora',
actionType: 'context menu'
actionType: actions.contextMenu
})

// Then "Alice" should see the content "As a user I want to create a document by clicking on a template file" in editor "Collabora"
Expand Down Expand Up @@ -1067,7 +1068,7 @@ test.describe('Integrate with online office suites like Collabora and OnlyOffice
// | Template (2).docx |
await ui.userShouldNotSeeTheResources({
world,
listType: 'files list',
listType: displayedResources.filesList,
stepUser: 'Alice',
resources: ['Template (2).docx']
})
Expand Down
15 changes: 8 additions & 7 deletions tests/e2e-playwright/specs/app-provider/secureView.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
import { test } from '../../support/test'
import * as api from '../../steps/api/api'
import * as ui from '../../steps/ui/index'
import { searchFilters, applications, actions } from '../../support/constants'

test.describe('Secure view', { tag: '@predefined-users' }, () => {
test.beforeEach(async ({ world }) => {
Expand Down Expand Up @@ -69,7 +70,7 @@ test.describe('Secure view', { tag: '@predefined-users' }, () => {
await ui.userSharesResources({
world,
stepUser: 'Alice',
actionType: 'SIDEBAR_PANEL',
actionType: actions.sideBarPanel,
shares: [
{
resource: 'secureDocument.odt',
Expand Down Expand Up @@ -101,7 +102,7 @@ test.describe('Secure view', { tag: '@predefined-users' }, () => {
world,
stepUser: 'Brian',
resource: 'secureDocument.odt',
application: 'Collabora'
application: applications.collabora
})

// we copy the contents of the file and compare the clipboard with the expected contents.
Expand Down Expand Up @@ -131,7 +132,7 @@ test.describe('Secure view', { tag: '@predefined-users' }, () => {
world,
stepUser: 'Brian',
resource: 'simple.pdf',
application: 'Collabora'
application: applications.collabora
})

// Then "Brian" should see the content "Copying from the document disabled" in editor "Collabora"
Expand All @@ -152,7 +153,7 @@ test.describe('Secure view', { tag: '@predefined-users' }, () => {
world,
stepUser: 'Brian',
resource: 'testavatar.jpeg',
application: 'Collabora'
application: applications.collabora
})

// Then "Brian" should see the content "Copying from the document disabled" in editor "Collabora"
Expand All @@ -173,7 +174,7 @@ test.describe('Secure view', { tag: '@predefined-users' }, () => {
world,
stepUser: 'Brian',
resource: 'lorem.txt',
application: 'Collabora'
application: applications.collabora
})

// Then "Brian" should see the content "Copying from the document disabled" in editor "Collabora"
Expand Down Expand Up @@ -231,7 +232,7 @@ test.describe('Secure view', { tag: '@predefined-users' }, () => {
await ui.userSharesResources({
world,
stepUser: 'Alice',
actionType: 'SIDEBAR_PANEL',
actionType: actions.sideBarPanel,
shares: [
{
resource: 'secureDocument.odt',
Expand Down Expand Up @@ -401,7 +402,7 @@ test.describe('Secure view', { tag: '@predefined-users' }, () => {
world,
stepUser: 'Brian',
keyword: 'secure',
filter: 'all files',
filter: searchFilters.allFiles,
command: 'presses enter'
})

Expand Down
17 changes: 9 additions & 8 deletions tests/e2e-playwright/specs/app-provider/urlJourneys.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
import { test } from '../../support/test'
import * as api from '../../steps/api/api'
import * as ui from '../../steps/ui/index'
import { applications, clients } from '../../support/constants'

test.describe('url stability for mobile and desktop client', { tag: '@predefined-users' }, () => {
test.beforeEach(async ({ world }) => {
Expand Down Expand Up @@ -54,8 +55,8 @@ test.describe('url stability for mobile and desktop client', { tag: '@predefined
stepUser: 'Alice',
resource: 'OpenDocument.odt',
space: 'personal',
editorName: 'Collabora',
client: 'desktop'
editorName: applications.collabora,
client: clients.desktop
})
// Then "Alice" should see the content "OpenDocument Content" in editor "Collabora"
await ui.userShouldSeeContentInEditor({
Expand All @@ -70,8 +71,8 @@ test.describe('url stability for mobile and desktop client', { tag: '@predefined
stepUser: 'Alice',
resource: 'MicrosoftWord.docx',
space: 'personal',
editorName: 'OnlyOffice',
client: 'desktop'
editorName: applications.onlyOffice,
client: clients.desktop
})
// Then "Alice" should see the content "Microsoft Word Content" in editor "OnlyOffice"
await ui.userShouldSeeContentInEditor({
Expand All @@ -88,8 +89,8 @@ test.describe('url stability for mobile and desktop client', { tag: '@predefined
stepUser: 'Alice',
resource: 'OpenDocument.odt',
space: 'personal',
editorName: 'Collabora',
client: 'mobile'
editorName: applications.collabora,
client: clients.mobile
})
// Then "Alice" should see the content "OpenDocument Content" in editor "Collabora"
await ui.userShouldSeeContentInEditor({
Expand All @@ -104,8 +105,8 @@ test.describe('url stability for mobile and desktop client', { tag: '@predefined
stepUser: 'Alice',
resource: 'MicrosoftWord.docx',
space: 'personal',
editorName: 'OnlyOffice',
client: 'mobile'
editorName: applications.onlyOffice,
client: clients.mobile
})
// Then "Alice" should see the content "Microsoft Word Content" in editor "OnlyOffice"
await ui.userShouldSeeContentInEditor({
Expand Down
Loading