[full-ci][tests-only] Rewrite search feature into playwrightonly#13555
Open
[full-ci][tests-only] Rewrite search feature into playwrightonly#13555
Conversation
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
nabim777
changed the title
53 tasks
nabim777
force-pushed
the
tests/search-feature
branch
5 times, most recently
from
4cc3e77 to
34cebd8
Compare
nabim777
requested review from
PrajwolAmatya,
Salipa-Gurung,
anon-pradip,
kavitagautam,
nirajacharya2 and
saw-jan
and removed request for
nirajacharya2
nabim777
force-pushed
the
tests/search-feature
branch
from
34cebd8 to
ce4e872
Compare
nabim777
force-pushed
the
tests/search-feature
branch
3 times, most recently
from
42fecd4 to
4123b85
Compare
saw-jan
reviewed
Feb 9, 2026
| await pageObject.delete({ | ||
| folder: parentFolder === '' ? null : parentFolder, | ||
| resourcesWithInfo: [{ name: file }], | ||
| via: actionType === 'batch action' ? 'BATCH_ACTION' : 'SIDEBAR_PANEL' |
Member
There was a problem hiding this comment.
you can create a const for the actionType and use that const instead of strings
const FileActionType = {
batchAction: 'BATCH_ACTION',
sidebarPanel: 'SIDEBAR_PANEL'
}
...
export async function deleteResource({
actionType = FileActionType.sidebarPanel
Member
Author
There was a problem hiding this comment.
I have updated with the const for the FileActionType.
nabim777
force-pushed
the
tests/search-feature
branch
from
326a921 to
19da97d
Compare
Signed-off-by: nabim777 <nabinalemagar019@gmail.com>
nabim777
force-pushed
the
tests/search-feature
branch
2 times, most recently
from
80b0f65 to
d14bda5
Compare
Signed-off-by: nabim777 <nabinalemagar019@gmail.com>
nabim777
force-pushed
the
tests/search-feature
branch
from
d14bda5 to
c00702c
Compare
|
saw-jan
reviewed
Feb 12, 2026
| file: string | ||
| actionType: string | ||
| resource: string | ||
| actionType: 'BATCH_ACTION' | 'SIDEBAR_PANEL' |
| type: 'user', | ||
| role: 'Can view', | ||
| resourceType: 'folder', | ||
| actionType: 'SIDEBAR_PANEL' |
| file: 'textfile.txt', | ||
| actionType: 'sidebar panel', | ||
| resource: 'textfile.txt', | ||
| actionType: 'SIDEBAR_PANEL', |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Rewrite the old Cucumber test from search/search.feature with only a playwright test.
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Open tasks: