Skip to content

fix: disable rename action in password-protected folder view #13512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
priyanshuharshbodhi1 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: disable rename action in password-protected folder view #13512

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7db795a
fix: disable rename action in password-protected folder view
priyanshuharshbodhi1 Jan 22, 2026
4908854
remove unnecessary comments
priyanshuharshbodhi1 Jan 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions changelog/unreleased/bugfix-disable-rename-in-ppf
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
Bugfix: Disable rename action in password-protected folder view

We've fixed a bug where renaming a folder from inside a password-protected
folder view would create a duplicate folder instead of renaming the original.
The rename action is now hidden in public link contexts, which aligns with
the documented behavior that link files should not be manipulated from this view.

https://github.com/owncloud/web/issues/12365
10 changes: 9 additions & 1 deletion packages/web-pkg/src/composables/actions/files/useFileActionsRename.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
import { isSameResource } from '../../../helpers/resource'
import { isLocationTrashActive, isLocationSharesActive } from '../../../router'
import {
isLocationTrashActive,
isLocationSharesActive,
isLocationPublicActive
} from '../../../router'
import { Resource } from '@ownclouders/web-client'
import { dirname, join } from 'path'
import { WebDAV } from '@ownclouders/web-client/webdav'
Expand Down Expand Up @@ -218,6 +222,10 @@ export const useFileActionsRename = () => {
if (isLocationTrashActive(router, 'files-trash-generic')) {
return false
}

if (isLocationPublicActive(router, 'files-public-link')) {
return false
}
if (
isLocationSharesActive(router, 'files-shares-with-me') &&
!capabilityStore.sharingCanRename
Expand Down