Skip to content

Conversation

@existentialcoder
Copy link

Description

  • Every time a new shared link is accessed with a password, two redundant calls are made to list the files
  • The first one is a watcher listener and a second is to verify password
  • This PR makes sure the watcher triggers the network call only during password verification.

Related Issue

Motivation and Context

Removed a duplicated call for the files-list when accessing a password protected shared link

How Has This Been Tested?

Unit and manual tests

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests
  • Documentation
  • Maintenance (e.g. dependency updates or tooling)

Open tasks:

  • ...

@update-docs
Copy link

update-docs bot commented Dec 26, 2025

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Password protected share gets authenticated twice

2 participants