[DC-227] implement the error items in the account folders view#12463
Open
[DC-227] implement the error items in the account folders view#12463
Conversation
Just to start, the error items are as simple as possible.
Also adjusted the constructor for the folder item updater to not take a parent because the folder item manages the lifetime of the updater.
also changed some blocks to use {} at Erik's request
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
this is just a passthrough to the accountState::isConnected but it's important to remove dependencies on account state. At base a folder should "know" if it is connected or not, regardless of how that is determined.
incorporated the folder connection state into menu actions states updated text for sync state: NotYetStarted "slow down" the progress updates as by default they are very granular. Now update limited to every 1 second
the folderitemdelegate now takes care of painting both the folder delegate and error items had to fool around to get the expander to show for the error items also fixed paints for the folder icon based on different possible non-square geometries (vertical/tall or horizontal/wide). with the current impl the folder icons do indeed get updated after changing them on the server, which is great because there was some trouble with that in the qml impl and never figured out why.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see https://kiteworks.atlassian.net/browse/DC-227