Skip to content

[FEATURE REQUEST] Take advantage of the search_min_length capability#4847

Merged
joragua merged 4 commits into
masterfrom
feature/search_min_length_capability
May 11, 2026
Merged

[FEATURE REQUEST] Take advantage of the search_min_length capability#4847
joragua merged 4 commits into
masterfrom
feature/search_min_length_capability

Conversation

@joragua
Copy link
Copy Markdown
Contributor

@joragua joragua commented May 8, 2026 •
edited
Loading

Related Issues

App: #4789

  • Add changelog files for the fixed issues in folder changelog/unreleased. More info here
  • Add feature to Release Notes in ReleaseNotesViewModel.kt creating a new ReleaseNote() with String resources (if required)

QA

@joragua joragua self-assigned this May 8, 2026
@joragua joragua linked an issue May 8, 2026 that may be closed by this pull request
[FEATURE REQUEST] Take advantage of the search_min_length capability #4789
Closed
10 tasks
@joragua joragua marked this pull request as ready for review May 8, 2026 11:56
@joragua joragua requested a review from jesmrec May 8, 2026 11:56
jesmrec
jesmrec requested changes May 8, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@jesmrec jesmrec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!! just a couple of comments @joragua

Comment thread .../main/java/com/owncloud/android/presentation/sharing/sharees/UsersAndGroupsSearchProvider.kt
Comment thread owncloudApp/src/main/java/com/owncloud/android/presentation/spaces/members/AddMemberFragment.kt Outdated
@joragua joragua requested a review from jesmrec May 11, 2026 07:39
jesmrec
jesmrec approved these changes May 11, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@jesmrec jesmrec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR approved, let's move to QA!

@jesmrec
Copy link
Copy Markdown
Contributor

jesmrec commented May 11, 2026

QA checks:

  • Clean installation
  • Update from previous version
  • search_min_length = 1
  • search_min_length = 2
  • search_min_length = 6
  • share with users

@jesmrec
Copy link
Copy Markdown
Contributor

jesmrec commented May 11, 2026

Approved on my side 🚀

@joragua joragua merged commit d80bc67 into master May 11, 2026
10 checks passed
@joragua joragua deleted the feature/search_min_length_capability branch May 11, 2026 10:21
@joragua joragua mentioned this pull request May 11, 2026
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jesmrec jesmrec jesmrec approved these changes

Assignees

@joragua joragua

Labels

Approved by qa

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[FEATURE REQUEST] Take advantage of the search_min_length capability

2 participants

@joragua @jesmrec