[FEATURE REQUEST] Add action to check source strings#4807
Open
[FEATURE REQUEST] Add action to check source strings#4807
Conversation
jesmrec
force-pushed
the
feature/add_action_check_source_strings
branch
4 times, most recently
from
7689a00 to
4bc6ef4
Compare
jesmrec
force-pushed
the
feature/add_action_check_source_strings
branch
2 times, most recently
from
1fa16c4 to
cf3a224
Compare
joragua
changed the title
joragua
requested changes
Mar 18, 2026
changelog/unreleased/4807
Outdated
Comment on lines
+1
to
+5
| Enhancement: GitHub action to validate source strings | ||
|
|
||
| A new GitHub action has been added to validate the source strings and prevent errors in translation ci system from the first step | ||
|
|
||
| https://github.com/owncloud/android/pull/4807 |
Collaborator
There was a problem hiding this comment.
IMO, I'd write the calens like this (juts to align all entries for workflows) 😄
A similar example: #4759
Suggested change
| Enhancement: GitHub action to validate source strings | |
| A new GitHub action has been added to validate the source strings and prevent errors in translation ci system from the first step | |
| https://github.com/owncloud/android/pull/4807 | |
| Enhancement: Workflow to validate source strings | |
| A new workflow has been added to validate the source strings and prevent errors in translation CI system from the first step | |
| https://github.com/owncloud/android/pull/4807 |
| <string name="create_space_dialog_empty_error">El nombre del space no puede estar vacío</string> | ||
| <string name="create_space_dialog_length_error">El nombre del space no puede exceder 255 caracteres</string> | ||
| <string name="create_space_dialog_characters_error">Caracteres prohibidos: / \\ . : \? * &quot; \' > < |</string> | ||
| <string name="create_space_dialog_characters_error">Caracteres prohibidos: / \\ . : \? * \" \' > < |</string> |
Collaborator
There was a problem hiding this comment.
I think there are more string files with &quot; and $quot; values:
values-de-rDE/strings.xml
values-de/strings.xml
They should be replaced, right? 🤔
Collaborator
Author
There was a problem hiding this comment.
Right, they seem to be added after the first task in the PR. Fixing...
| <string name="auth_unsupported_auth_method">The server does not support this authentication method</string> | ||
| <string name="auth_fail_get_user_name">Your server is not returning a correct user ID. Please contact an administrator. | ||
| </string> | ||
| <string name="auth_fail_get_user_name">Your server is not returning a correct user ID. Please contact an administrator.</string> |
Collaborator
There was a problem hiding this comment.
The same for indentation. I think there are more string files that need a refactor
Collaborator
Author
There was a problem hiding this comment.
In this case, i put the focus in the strings.xml because is the only file that the workflow checks. Would it be a good idea to check all the translations file to indent or remove line breaks?
Collaborator
Author
There was a problem hiding this comment.
The number of involved strings is very high... it may not woth
jesmrec
force-pushed
the
feature/add_action_check_source_strings
branch
from
a499e9f to
4bf06c0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two actions were addressed here:
In the
strings.xmlfile, some tiny changes to normalize the file against the validation script: remove some useless line breaks, and replace"for the escaped\"The action will run a script to check if every string in
strings.xmlcontains any forbidden character (non-escaped). The list of forbidden characters is set inside the script (i expect the list to be very static). The utilxmlstarletwill be used to parse the xml file and provide every entry one by one by using the process substitution operationFor the moment, the check will not be mandatory. Let's give a try, and, if it works fine, we could become mandatory
Related Issues
App:
ReleaseNotesViewModel.ktcreating a newReleaseNote()with String resources (if required)QA