Fix: Include posterTimestamp in JWT claims for signed playback URLs #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HarryParkes
commented
Jan 14, 2026
HarryParkes
commented
- Add params object with time claim when signing thumbnail JWT
- Fixes issue posterTimestamp not working with signed playback URLs #23 where posterTimestamp didn't affect signed URLs
- For signed policies, thumbnail options must be in JWT claims per Mux docs"
- Add params object with time claim when signing thumbnail JWT - Fixes issue oversightstudio#23 where posterTimestamp didn't affect signed URLs - For signed policies, thumbnail options must be in JWT claims per Mux docs"
There was a problem hiding this comment.
Pull request overview
This PR fixes an issue where the posterTimestamp parameter was not being properly included in JWT claims for signed playback URLs when generating animated GIF thumbnails. When using Mux's signed playback policies, thumbnail options must be included in the JWT claims rather than just as query parameters.
Changes:
- Added
paramsobject with time claim to JWT signing call for GIF URLs whenposterTimestampis set - Ensures signed GIF URLs respect the posterTimestamp setting per Mux documentation requirements
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| const token = await mux.jwt.signPlaybackId(playbackId, { | ||
| expiration: pluginOptions.signedUrlOptions?.expiration ?? '1d', | ||
| type: 'gif', | ||
| params: typeof posterTimestamp === 'number' ? { time: posterTimestamp.toString() } : undefined, |
There was a problem hiding this comment.
The indentation on this line uses tabs instead of spaces, which is inconsistent with the rest of the file. This line should be indented with spaces to match the existing code style.
Suggested change
| params: typeof posterTimestamp === 'number' ? { time: posterTimestamp.toString() } : undefined, | |
| params: typeof posterTimestamp === 'number' ? { time: posterTimestamp.toString() } : undefined, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.