Skip to content

fixing error if message is already served or not matched #379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
invisal merged 1 commit into from
Feb 27, 2025
Merged

fixing error if message is already served or not matched #379

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 17 additions & 13 deletions src/drivers/iframe-driver.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,17 +6,17 @@ import { SqliteLikeBaseDriver } from "./sqlite-base-driver";

type ParentResponseData =
| {
type: "query";
id: number;
data: DatabaseResultSet;
error?: string;
}
type: "query";
id: number;
data: DatabaseResultSet;
error?: string;
}
| {
type: "transaction";
id: number;
data: DatabaseResultSet[];
error?: string;
};
type: "transaction";
id: number;
data: DatabaseResultSet[];
error?: string;
};

type PromiseResolveReject = {
resolve: (value: any) => void;
Expand All @@ -29,6 +29,10 @@ class IframeConnection {

listen() {
const handler = (e: MessageEvent<ParentResponseData>) => {
// Make no sense to handle message with no matching id
// This throw a lot of error in console for some reason
if (!this.queryPromise[e.data.id]) return;

if (e.data.error) {
this.queryPromise[e.data.id].reject(e.data.error);
delete this.queryPromise[e.data.id];
Expand Down Expand Up @@ -124,7 +128,7 @@ export class IframeSQLiteDriver extends SqliteLikeBaseDriver {
this.conn.listen();
}

close(): void {}
close(): void { }

async query(stmt: string): Promise<DatabaseResultSet> {
const r = await this.conn.query(stmt);
Expand All @@ -147,7 +151,7 @@ export class IframeMySQLDriver extends MySQLLikeDriver {
this.conn.listen();
}

close(): void {}
close(): void { }

async query(stmt: string): Promise<DatabaseResultSet> {
const r = await this.conn.query(stmt);
Expand Down Expand Up @@ -179,7 +183,7 @@ export class IframePostgresDriver extends PostgresLikeDriver {
this.conn.listen();
}

close(): void {}
close(): void { }

async query(stmt: string): Promise<DatabaseResultSet> {
const r = await this.conn.query(stmt);
Expand Down