test: cover handler query validation#197
Open
JetMatrix wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/claim #71
Summary
400validation responses for malformed transaction SQL and params instead of falling through to the generic500error path.src/handler.test.tscoverage for non-JSON query requests, invalid query params, raw transaction forwarding with params, invalid transaction SQL, and invalid transaction params.Verification
.\node_modules\.bin\vitest.cmd run src/handler.test.ts-> 13 tests passed.\node_modules\.bin\vitest.cmd run src/handler.test.ts --coverage.enabled true --coverage.include src/handler.ts --coverage.reporter text --coverage.thresholds.lines=0 --coverage.thresholds.branches=0 --coverage.thresholds.functions=0 --coverage.thresholds.statements=0-> passed;src/handler.tsreports 59.63% statements / 63.33% branches / 29.62% functions / 61.32% lines in the focused run.\node_modules\.bin\prettier.cmd --check src/handler.ts src/handler.test.ts-> passedgit diff --check -- src/handler.ts src/handler.test.ts-> passed with Windows CRLF warnings only.\node_modules\.bin\vitest.cmd run-> new handler tests pass; current main still has 4 unrelated baseline failures insrc/rls/index.test.tsNotes