Skip to content

AO3-7292 Remove Wrangler (X) Button on Tag Wranglers Page Clickable Area Matches Text Rather Than Button #5649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brianjaustin merged 3 commits into from
Mar 28, 2026
Merged

AO3-7292 Remove Wrangler (X) Button on Tag Wranglers Page Clickable Area Matches Text Rather Than Button #5649

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
01c9abd
Remove wrangler (x) button on tag wranglers page, make clickable area…
ScottVenkataraman Mar 20, 2026
cd329bf
Syntax changes for appropraite version syntax
ScottVenkataraman Mar 20, 2026
582c553
Update tag_wrangling tests to use × instead of x
ScottVenkataraman Mar 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions app/views/tag_wranglers/index.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,8 @@
<li>
<%= link_to wrangler, tag_wrangler_path(:id => wrangler) %>
<!--BACK END PLS take off this span and give the link the class delete-->
<span class="action" title="remove">
<%= link_to 'x', tag_wrangler_path(redirect_params.merge(:id => wrangler, :fandom_id => assignments.first.id)), :method => :delete %>
<span class="delete">
<%= link_to "×", tag_wrangler_path(redirect_params.merge(id: wrangler, fandom_id: assignments.first.id)), method: :delete, title: "remove" %>
</span>
</li>
<% end %>
Expand Down
2 changes: 1 addition & 1 deletion features/tags_and_wrangling/tag_wrangling_admin.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ Feature: Tag wrangling
Given the tag wrangler "tangler" with password "wr@ngl3r" is wrangler of "Testing"
When I am logged in as a "tag_wrangling" admin
And I am on the wranglers page
And I follow "x"
And I follow "×"
Then I should see "Wranglers were successfully unassigned!"
And "Testing" should not be assigned to the wrangler "tangler"
When I edit the tag "Testing"
Expand Down
4 changes: 2 additions & 2 deletions features/tags_and_wrangling/tag_wrangling_more.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ Feature: Tag wrangling: assigning wranglers, using the filters on the Wranglers
Given the tag wrangler "tangler" with password "wr@ngl3r" is wrangler of "Testing"
And I am logged in as "tangler" with password "wr@ngl3r"
When I am on the wranglers page
And I follow "x"
And I follow "×"
Then I should see "Wranglers were successfully unassigned!"
And "Testing" should not be assigned to the wrangler "tangler"
When I edit the tag "Testing"
Expand All @@ -104,7 +104,7 @@ Feature: Tag wrangling: assigning wranglers, using the filters on the Wranglers
| wranglerette |
When I am logged in as "wranglerette"
And I am on the wranglers page
And I follow "x"
And I follow "×"
Then I should see "Wranglers were successfully unassigned!"
And "Testing" should not be assigned to the wrangler "tangler"
When I edit the tag "Testing"
Expand Down
Loading