AO3-7165 Fix picking skin from chooser without javascript#5639
Open
Bilka2 wants to merge 1 commit intootwcode:masterfrom
Open
AO3-7165 Fix picking skin from chooser without javascript#5639Bilka2 wants to merge 1 commit intootwcode:masterfrom
Bilka2 wants to merge 1 commit intootwcode:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
https://otwarchive.atlassian.net/browse/AO3-7165
Purpose
Change the skin chooser to cache just the skin data instead of the whole HTML fragment. Don't expire the skin chooser cache when unrelated skins change.
No automated tests because I couldn't figure out any way to make them fail without the change. I suspect that whatever the testing framework is doing is bypassing the problem, similar to how javascript does.
Credit
Bilka