AO3-7321 Obfuscate unrevealed work in subscriptions page#5626
Open
danielh-official wants to merge 12 commits intootwcode:masterfrom
Conversation
Bilka2
requested changes
Mar 19, 2026
Contributor
Bilka2
left a comment
Bilka2
left a comment
There was a problem hiding this comment.
Thank you for working on this!
| </dd> | ||
| <% elsif subscription.subscribable && subscription.subscribable.try(:unrevealed?) %> | ||
| <dt> | ||
| <%= t(".mystery_work") %> |
Contributor
There was a problem hiding this comment.
the "(Work)" text should still be present here, like for a normal work
Contributor
Author
There was a problem hiding this comment.
So it would be like Mystery Work (Work)?
danielh-official
force-pushed
the
AO3-7321-Titles-and-creators-of-unrevealed-works-are-visible-on-the-subscriptions-page
branch
from
566ed06 to
a6fd267
Compare
github-actions
bot
added
Coder Has Actioned Review
and removed
Reviewed: Action Needed
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
as the first thing in your pull request title (e.g.
AO3-1234 Fix thing)until they are reviewed and merged before creating new pull requests.
Issue
https://otwarchive.atlassian.net/browse/AO3-7321
Purpose
If a user subscribes to a work that is then put into an unrevealed collection, the work appears as "Mystery Work" in their subscriptions page:
users/{user}/subscriptions.Before
After
Notes
Requirements from A03-7321:
To align with the requirements, I made it so that for all subscribables where "unrevealed" is a valid method that returns true, the label is "Mystery Work".
However, a series can be made "unrevealed" as well. It might be a good idea to change the wording to "Mystery Series" if the subscribable's type is a series instead of a work.